Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PromiseProxy Deprecation for Save #8025

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fix: PromiseProxy Deprecation for Save #8025

merged 2 commits into from
Jul 15, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Jul 15, 2022 •
edited
Loading

reboot of #8000 which targeted the wrong branch. Also extends the test coverage to make sure we didn't leak through the new proxy.

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue labels Jul 15, 2022
@github-actions
Copy link

github-actions bot commented Jul 15, 2022 •
edited
Loading

Asset Size Report for 0b22fc6

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

Performance Report for 0b22fc6

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-3ms to 44ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-14ms to 11ms]
⚠️ Phase [start-find-all] => [start-materialization]
phase estimated regression +17ms [2ms to 31ms] OR +2.11% [0.25% to 3.85%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-14ms to 12ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-3ms to 5ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-27ms to 37ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-21ms to 13ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-17ms to 32ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-4ms to 13ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-26ms to 55ms]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +22ms [2ms to 38ms] OR +3.36% [0.29% to 5.61%]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-21ms to 24ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-20ms to 11ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-36ms to 7ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-30ms to 3ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-14ms to 7ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 5ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 4ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 30ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -17ms [-34ms to 0ms] OR -2.49% [-4.8% to -0.03%]
⚠️ Phase [start-push-payload] => [end-push-payload]
phase estimated regression +22ms [2ms to 42ms] OR +1.51% [0.12% to 2.79%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-5ms to 1ms]

@runspired runspired merged commit ae20278 into master Jul 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/fix-8000 branch July 15, 2022 01:34
@runspired runspired mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runspired @Turbo87